Bug 2013527 - finer-grained locking for remote settings#7197
Merged
bendk merged 1 commit intomozilla:mainfrom Feb 12, 2026
Merged
Bug 2013527 - finer-grained locking for remote settings#7197bendk merged 1 commit intomozilla:mainfrom
bendk merged 1 commit intomozilla:mainfrom
Conversation
ccbe0d1 to
e71c910
Compare
e71c910 to
1ba2946
Compare
skhamis
approved these changes
Feb 12, 2026
Contributor
skhamis
left a comment
There was a problem hiding this comment.
Sorry this fell through the cracks for review, nice job! LGTM!
1ba2946 to
96d82b2
Compare
Made it so `update_config` doesn't directly mutate the `RemoteSettingsClientInner` value, it just sets value in `pending_config` that will be applied the next time the client is locked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made it so
update_configdoesn't directly mutate theRemoteSettingsClientInnervalue, it just sets value inpending_configthat will be applied the next time the client is locked.Pull Request checklist
[ci full]to the PR title.