Skip to content

Bug 2013527 - finer-grained locking for remote settings#7197

Merged
bendk merged 1 commit intomozilla:mainfrom
bendk:push-kqyqsoypwror
Feb 12, 2026
Merged

Bug 2013527 - finer-grained locking for remote settings#7197
bendk merged 1 commit intomozilla:mainfrom
bendk:push-kqyqsoypwror

Conversation

@bendk
Copy link
Contributor

@bendk bendk commented Jan 30, 2026

Made it so update_config doesn't directly mutate the RemoteSettingsClientInner value, it just sets value in pending_config that will be applied the next time the client is locked.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@bendk bendk requested review from a team and skhamis January 30, 2026 16:23
@bendk bendk force-pushed the push-kqyqsoypwror branch from ccbe0d1 to e71c910 Compare January 30, 2026 16:29
@bendk bendk force-pushed the push-kqyqsoypwror branch from e71c910 to 1ba2946 Compare February 11, 2026 22:58
Copy link
Contributor

@skhamis skhamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this fell through the cracks for review, nice job! LGTM!

@bendk bendk force-pushed the push-kqyqsoypwror branch from 1ba2946 to 96d82b2 Compare February 12, 2026 14:30
@bendk bendk enabled auto-merge February 12, 2026 14:30
Made it so `update_config` doesn't directly mutate the
`RemoteSettingsClientInner` value, it just sets value in
`pending_config` that will be applied the next time the client is
locked.
@bendk bendk added this pull request to the merge queue Feb 12, 2026
Merged via the queue into mozilla:main with commit 8bf1e32 Feb 12, 2026
13 checks passed
@bendk bendk deleted the push-kqyqsoypwror branch February 12, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants